Skip to content

Manchester | 26-ITP-Jan | Liban Jama | Sprint 1 | Object Destructing#406

Closed
libanj0161 wants to merge 7 commits into
CodeYourFuture:mainfrom
libanj0161:feature/destructuring
Closed

Manchester | 26-ITP-Jan | Liban Jama | Sprint 1 | Object Destructing#406
libanj0161 wants to merge 7 commits into
CodeYourFuture:mainfrom
libanj0161:feature/destructuring

Conversation

@libanj0161
Copy link
Copy Markdown

@libanj0161 libanj0161 commented Apr 5, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed exercises 1, 2, and 3.

Questions

N/A.

@libanj0161 libanj0161 changed the title Manchester | 26-ITP-Jan | Khalidbih | Sprint 1 | Object Destructing Manchester | 26-ITP-Jan | Liban Jama | Sprint 1 | Object Destructing Apr 5, 2026
@libanj0161 libanj0161 added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Apr 5, 2026
@libanj0161
Copy link
Copy Markdown
Author

libanj0161 commented Apr 5, 2026

i copied another colleague's title but forgot to change it to my name. The work is mine

@Luro91 Luro91 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 10, 2026
Luro91
Luro91 reviewed Apr 10, 2026
View reviewed changes
Comment thread Sprint-1/destructuring/exercise-2/exercise.js
Copy link
Copy Markdown

@Luro91 Luro91 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any output on the console when I run this exercise

Copy link
Copy Markdown
Author

@libanj0161 libanj0161 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added console logs

Copy link
Copy Markdown

@Luro91 Luro91 Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you verifying that the output is correct?

Comment thread Sprint-1/destructuring/exercise-3/exercise.js Outdated
Comment on lines +17 to +19
const itemName = item.itemName;
const quantity = item.quantity;
const unitPricePence = item.unitPricePence;
Copy link
Copy Markdown

@Luro91 Luro91 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can you use destructuring here?

Copy link
Copy Markdown
Author

@libanj0161 libanj0161 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited after feedback

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 10, 2026
@libanj0161 libanj0161 requested a review from Luro91 April 11, 2026 12:16
@libanj0161 libanj0161 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 11, 2026
@Luro91 Luro91 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 12, 2026
Luro91
Luro91 reviewed Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown

@Luro91 Luro91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't see output for exercise 2

@libanj0161
Copy link
Copy Markdown
Author

libanj0161 commented Apr 14, 2026 •
edited
Loading

I still don't see output for exercise 2

I called the function at the bottom of the file to see the output of the console log findTeachersWithPets(hogwarts) and findGryffindor(hogwarts). Is this what you mean?

Screenshot 2026-04-14 at 10 55 40

@libanj0161 libanj0161 requested a review from Luro91 April 14, 2026 09:56
@libanj0161 libanj0161 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 14, 2026
@Luro91
Copy link
Copy Markdown

Luro91 commented Apr 15, 2026

I still don't see output for exercise 2

I called the function at the bottom of the file to see the output of the console log findTeachersWithPets(hogwarts) and findGryffindor(hogwarts). Is this what you mean?
Screenshot 2026-04-14 at 10 55 40

Did you push the changes where the functions are called? At the moment there is no output

@Luro91 Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
@libanj0161
Copy link
Copy Markdown
Author

libanj0161 commented Apr 15, 2026 •
edited
Loading

Pushed the code where i called the functions

@libanj0161 libanj0161 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
Luro91
Luro91 reviewed Apr 16, 2026
View reviewed changes
Comment thread Sprint-1/destructuring/exercise-2/exercise.js Outdated
});

const output = peopleNames.join("\n");
console.log("People in Gryffindor House", output);
Copy link
Copy Markdown

@Luro91 Luro91 Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could you improve the formatting of the output? (so that the headers are on top)

Teachers with pets Albus Dumbledore
People in Gryffindor House Harry Potter
Ron Weasley
Hermione Granger
Minerva McGonagall
Albus Dumbledore

@Luro91 Luro91 removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Apr 16, 2026
@libanj0161
Copy link
Copy Markdown
Author

libanj0161 commented Apr 16, 2026

Improved formatting so that headers are at the top.

@libanj0161 libanj0161 requested a review from Luro91 April 16, 2026 16:39
Luro91
Luro91 reviewed Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown

@Luro91 Luro91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The teachers with pets header could also use a new line. Otherwise looks good

@Luro91 Luro91 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 17, 2026
@illicitonion
Copy link
Copy Markdown
Member

illicitonion commented May 4, 2026

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Luro91 Luro91 Luro91 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Flows The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@libanj0161 @Luro91 @illicitonion